From 3116713672bbcf6aec50439537e451646bc9a11a Mon Sep 17 00:00:00 2001 From: Thomas Koch Date: Sun, 10 Jul 2022 09:13:34 +0000 Subject: rm buildDate from build.xml and its usages The https://reproducible-builds.org project invests a lot of work to make builds reproducible. This is a security property. It allows to compare the build of binaries from different builder machines. If they are identical, it means that either the builds have not been manipulated or an attacker managed to attack all builder machines in exactly the same way. One problem that the reproducible-builds project often sees is that projects include the build time in their binaries. This makes builds unreproducible for apparently no reason. The build date should not be of interest since binaries built on different dates but from the same source code should not be different. Thus I decided to remove the build date instead of re-implementing the functionality without the GitRev task. Anyways the reported date was not the build date but the date of the last git commit which is even less informative. The git commit ID would have information value but should only be relevant for "nightly builds". --- build.nsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'build.nsi') diff --git a/build.nsi b/build.nsi index 6587e3810..cdd7218de 100644 --- a/build.nsi +++ b/build.nsi @@ -30,10 +30,10 @@ VIAddVersionKey "ProductName" "YaCy" VIAddVersionKey "LegalCopyright" "YaCy" VIAddVersionKey "FileVersion" "@REPL_VERSION@" VIAddVersionKey "FileDescription" "YaCy" -VIAddVersionKey "OriginalFilename" "yacy_v@REPL_VERSION@_@REPL_DATE@_@REPL_REVISION_NR@.exe" +VIAddVersionKey "OriginalFilename" "yacy_v@REPL_VERSION@_@REPL_REVISION_NR@.exe" Name "YaCy @REPL_VERSION@" -OutFile "RELEASE\WINDOWS\yacy_v@REPL_VERSION@_@REPL_DATE@_@REPL_REVISION_NR@.exe" +OutFile "RELEASE\WINDOWS\yacy_v@REPL_VERSION@_@REPL_REVISION_NR@.exe" ;default installation folder InstallDir "$PROFILE\YaCy" @@ -95,7 +95,7 @@ SetCompressor /SOLID LZMA !define MUI_COMPONENTSPAGE_NODESC !insertmacro MUI_PAGE_COMPONENTS -ComponentText "YaCy v@REPL_VERSION@ (Build @REPL_DATE@)" +ComponentText "YaCy v@REPL_VERSION@" !define MUI_PAGE_CUSTOMFUNCTION_LEAVE CheckDriveSpace !insertmacro MUI_PAGE_DIRECTORY -- cgit v1.2.3